Skip to content

Conversation

@QxBytes
Copy link
Contributor

@QxBytes QxBytes commented Oct 2, 2025

Reason for Change:

Start building images during the unit test stage, remove cluster create dependency on image build, move npm manifest creation to new stage. Aiming to speed up pipeline runs.

Issue Fixed:

See above

Requirements:

Notes:
Latest: https://msazure.visualstudio.com/One/_build/results?buildId=139113170
POC: https://msazure.visualstudio.com/One/_build/results?buildId=139103901

the images should only be required during the e2e stage after cluster creation
the e2e stage is already dependent on publish multiarch manifests, which is
already dependent on build images; thus, all e2e stages are implictly
dependent on the build image stage success
@QxBytes QxBytes self-assigned this Oct 2, 2025
@QxBytes QxBytes added the ci Infra or tooling. label Oct 2, 2025
@QxBytes QxBytes changed the title Alew/shortcircuit test ci: pipeline stage reorganization Oct 2, 2025
@QxBytes QxBytes changed the title ci: pipeline stage reorganization ci: reorganize pipeline stages Oct 2, 2025
@QxBytes QxBytes marked this pull request as ready for review October 3, 2025 16:43
@QxBytes QxBytes requested a review from a team as a code owner October 3, 2025 16:43
@QxBytes QxBytes requested review from Copilot and neaggarwMS October 3, 2025 16:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reorganizes the CI pipeline stages to improve build efficiency by restructuring dependencies and parallelizing operations. The changes aim to speed up pipeline execution by allowing image builds to start during unit tests and removing unnecessary dependencies between stages.

  • Removed dependency on test stage for build and containerize stages to allow parallel execution
  • Created a separate publish_npm stage for NPM multiarch manifest creation
  • Changed E2E test dependencies from "containerize" to "test" to enable cluster creation without waiting for image builds

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@jpayne3506 jpayne3506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving NPM manifest stage to its own stage can potentially save us 20-30 minutes. Thank you for this change @QxBytes

@QxBytes QxBytes added this pull request to the merge queue Oct 3, 2025
Merged via the queue into master with commit cf7f359 Oct 3, 2025
105 of 107 checks passed
@QxBytes QxBytes deleted the alew/shortcircuit-test branch October 3, 2025 21:19
sivakami-projects pushed a commit that referenced this pull request Oct 23, 2025
* shortcircuit ut

* test multi dependency

* split npm manifest out

* remove dependency of create cluster on build images in acn pr pipeline

the images should only be required during the e2e stage after cluster creation
the e2e stage is already dependent on publish multiarch manifests, which is
already dependent on build images; thus, all e2e stages are implictly
dependent on the build image stage success
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Infra or tooling.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants